Skip to content

Conversation

@jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented May 10, 2025

Description

This updates the stack playground to use the new helm chart from the github.com/tinkerbell/tinkerbell repo.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This is the supported helm chart.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock requested a review from Copilot May 10, 2025 15:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the deployment configuration to use the new tinkerbell chart repository and adjusts related network and environment settings.

  • Updated the helm chart source from "tinkerbell/charts/stack" to "tinkerbell/charts/tinkerbell" and switched relevant chart value keys in setup.sh.
  • Introduced a new variable (LOADBALANCER_IP_2) and updated IPs both in the Vagrantfile and the .env file.
  • Changed the hostPath for hook artifacts in ubuntu-download.yaml.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
stack/vagrant/ubuntu-download.yaml Changed hook-artifacts hostPath from "/opt/hook" to "/tmp".
stack/vagrant/setup.sh Updated helm_install_tink_stack and run_helm functions with new chart source and extra parameter.
stack/vagrant/Vagrantfile Adjusted environment variable values and shell provisioner arguments.
stack/vagrant/.env Updated environment variables including helm chart version and loadbalancer IPs.
Comments suppressed due to low confidence (2)

stack/vagrant/ubuntu-download.yaml:51

  • Changing the hostPath for hook-artifacts from '/opt/hook' to '/tmp' may lead to unexpected data loss since /tmp is typically cleared on reboot. Verify that this change is intentional and that the artifacts do not require persistent storage.
path: /tmp

stack/vagrant/setup.sh:77

  • Ensure that the updated chart source and new helm value keys (e.g., artifactsFileServer, deployment.init.sourceInterface, kubevip.interface) are fully compatible with the upstream tinkerbell chart configuration. Consider adding a comment or reference to the new chart documentation for clarity.
helm install tink-stack oci://ghcr.io/tinkerbell/charts/tinkerbell \

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock merged commit 091b761 into tinkerbell:main May 12, 2025
6 checks passed
@jacobweinstock jacobweinstock deleted the use-tinkerbell-tinkerbell branch May 12, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant