Skip to content

kernman: Finish implement of name expansion in KernelInfo #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phodina wants to merge 2 commits into
base: master
Choose a base branch
from
Open

kernman: Finish implement of name expansion in KernelInfo #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384a7ac
kernman: Finish implement of name expansion in KernelInfo
Jan 29, 2026
de0d87e
Handle the failure in the kernel info properly
Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/kerman.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ impl KernelInfo {

let out = Command::new(MOD_INFO_EXE).arg(name).output();
match out {
Ok(_) => match String::from_utf8(out.unwrap().stdout) {
Ok(output) => match String::from_utf8(output.stdout) {
Ok(data) => {
for line in data.lines().map(|el| el.replace(' ', "")) {
if line.starts_with("filename:/") && line.contains("/kernel/") {
Expand All @@ -194,9 +194,15 @@ impl KernelInfo {
}
}
}
Err(_) => todo!(),
Err(e) => {
// Failed to parse UTF-8 from modinfo output
eprintln!("Warning: Failed to parse modinfo output for '{}': {}", name, e);
}
},
Err(_) => todo!(),
Err(e) => {
// Failed to execute modinfo command
eprintln!("Warning: Failed to execute modinfo for '{}': {}", name, e);
}
}

name
Expand Down
6 changes: 3 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ pub fn get_kernel_infos(rootfs: Option<&str>) -> Result<Vec<KernelInfo>, Error>

let mut kernels: Vec<KernelInfo> = vec![];

for fres in read_dir(format!("{}{}", rfs_path.trim_end_matches("/"), MOD_D)).unwrap() {
let fd = fres.unwrap();
if fd.file_type().unwrap().is_dir() {
for fres in read_dir(format!("{}{}", rfs_path.trim_end_matches("/"), MOD_D))? {
let fd = fres?;
if fd.file_type()?.is_dir() {
let kinfo: KernelInfo =
KernelInfo::new(rfs_path, fd.path().file_name().unwrap().to_str().unwrap())?;
if kinfo.is_valid() {
Expand Down