Skip to content

Comments

Test and fix for Csv.toFrame bug#65

Open
darrenjw wants to merge 2 commits intotixxit:masterfrom
darrenjw:master
Open

Test and fix for Csv.toFrame bug#65
darrenjw wants to merge 2 commits intotixxit:masterfrom
darrenjw:master

Conversation

@darrenjw
Copy link

This PR introduces a test illustrating the bug in Csv.toFrame (Issue #64), and a possible fix for it.

@tixxit
Copy link
Owner

tixxit commented Nov 26, 2015

Thanks for this! The fix seems to work, but I'm a little concerned about doing an extraction per row with Rows vs the more batch-able Cols approach (for performance reasons). I'll take a look though and see if there is anything we can do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants