ability to specify command when hitting enter #1223
Conversation
jjb
force-pushed
the
default-empty-command-behavior
branch
from
cc5edfe to
1b79340
Compare
jjb
force-pushed
the
default-empty-command-behavior
branch
from
1b79340 to
7654970
Compare
| Any arguments to git repl will be taken as the first command to execute in | ||
| the repl. | ||
|
|
||
| You can specify a default command to run when hitting enter: |
There was a problem hiding this comment.
Let's also update https://github.com/tj/git-extras/blob/main/man/git-repl.md and generate new man page
bin/git-repl
Outdated
| if test -n "$on_enter_cmd"; then | ||
| eval "$on_enter_cmd" | ||
| fi | ||
| continue |
There was a problem hiding this comment.
The continue will skip exit_status=$? below?
There was a problem hiding this comment.
before my change, when there was an empty command, the result was continue
after my change, now there is the optional command executed, and then always continue like before
(maybe you know this and are asking something else)
i just now tested the exit_status feature with and without git-extras.repl.on-enter-command being set and it still works
There was a problem hiding this comment.
@jjb
So the custom command, unlike the command input for prompt, doesn't affect the exit status. Is it intended?
There was a problem hiding this comment.
oh i see
i'm not sure if persisting the default commands status would be useful, but i also don't know the use case for normal commands either. so the user knows the exit code just in case different non-0 codes have meaning?
There was a problem hiding this comment.
happy to make the dfault command also do this
There was a problem hiding this comment.
I guess it is used to provide a feature like echo $?, since the $? is not available in the next prompt.
There was a problem hiding this comment.
okay, fixed that, and it's a nice improvement anyway because we are running the command through the normal command evaling logic
hyperupcall
left a comment
hyperupcall
left a comment
There was a problem hiding this comment.
This LGTM assuming the comments by @spacewander are addressed!
impetuous: persist return val for display in promt if non-zero also future-proofs for other benefits / DRYness. no need for another eval invocation.
| "") continue;; | ||
| "") | ||
| on_enter_cmd=$(git config --get --default '' git-extras.repl.on-enter-command) | ||
| if test -n "$on_enter_cmd"; then |
There was a problem hiding this comment.
i did test that this is false when the setting is unset (i.e. test -n is false for blank string)
|
@jjb |
3 participants
closes #1222