Email recovery cleanup #521
Conversation
ethankonk
left a comment
ethankonk
left a comment
There was a problem hiding this comment.
Some small nits, otherwise I think it looks good!
| ### Credential bundle method | ||
|
|
||
| **Note:** on web, this method is only supported with the legacy iframe-based flow, if no hard requirement to use encrypted bundles, we suggest to use the IndexedDB-based OTP flow instead. | ||
| **Note:** This method is only supported by **legacy iframe-based flows** and is not available in the current Turnkey SDKs. |
There was a problem hiding this comment.
Started recently using our <Note></Note> component, I find it looks much better, could be used here!
| **Note:** This method is only supported by **legacy iframe-based flows** and is not available in the current Turnkey SDKs. | |
| <Note> **Note:** This method is only supported by **legacy iframe-based flows** and is not available in the current Turnkey SDKs. </Note> |
Makes it looks like this:
| | | public_key | string | The public key of the credential that approved the request | | ||
| | **Activity** | type | string | The type of the activity (e.g. ACTIVITY_TYPE_SIGN_TRANSACTION_V2) | | ||
| | | resource | string | The resource type the activity targets: `USER`, `PRIVATE_KEY`, `POLICY`, `WALLET`, `ORGANIZATION`, `INVITATION`, `CREDENTIAL`, `CONFIG`, `RECOVERY`, `AUTH`, `OTP`, `PAYMENT_METHOD`, `SUBSCRIPTION` | | ||
| | | resource | string | The resource type the activity targets: `USER`, `PRIVATE_KEY`, `POLICY`, `WALLET`, `ORGANIZATION`, `INVITATION`, `CREDENTIAL`, `CONFIG`, `AUTH`, `OTP`, `PAYMENT_METHOD`, `SUBSCRIPTION` | |
There was a problem hiding this comment.
Can we no longer target RECOVERY resource types? Even though we plan on deprecating the email recovery activities, I still feel we should keep it in some parts of our docs for legacy customers or anyone choosing to use the deprecated methods for whatever reason
Not too opinionated on this so if you feel we should remove it altogether feel free!
There was a problem hiding this comment.
I'm down to keep references in the policies documentation. We can add (deprecated) just in case.
| | | DELETE | ACTIVITY_TYPE_DELETE_PAYMENT_METHOD | | ||
| | **SUBSCRIPTION** | CREATE | ACTIVITY_TYPE_ACTIVATE_BILLING_TIER | | ||
| | **CONFIG** | UPDATE | ACTIVITY_TYPE_UPDATE_ALLOWED_ORIGINS | | ||
| | **RECOVERY** | CREATE | ACTIVITY_TYPE_INIT_USER_EMAIL_RECOVERY | |
andrewkmin
left a comment
andrewkmin
left a comment
There was a problem hiding this comment.
Thanks for tackling this. Should be strong enough to steer people away from recovery; if people still somehow get confused, we could include some more explicit deprecation notices.
No description provided.