Skip to content

Conversation

@r-n-o
Copy link
Contributor

@r-n-o r-n-o commented Jan 14, 2026

In #35 I switched the main CI workflow to trigger on pull_request_target to make external contributions easier. The intent was to let PRs from forks run CI, with approval.

Turns out the approval part doesn't work and external contributors can run CI without an approval. The secret in this workflow is inconsequential but it's still bad practice to leave the current workflow as-is.

Looking at the Github documentation, it clearly states:

This event runs in the context of the default branch of the base repository, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow. This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

Copy link
Contributor

@cr-tk cr-tk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as per internal discussion.

@r-n-o r-n-o merged commit 5e524a0 into main Jan 14, 2026
4 checks passed
@r-n-o r-n-o mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants