This repository was archived by the owner on Dec 23, 2024. It is now read-only.
begin genericizing this so that editing config won't show up in git changes #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is exactly the path you want to take upstream, I'm just offering to help sort of make this more generic and usable for others like me who appreciate your work.
I'm not sure off-hand if there are any other environment-specific file contents outside of site.rb, but if so I considered a script that generates them from a .json.
An interesting default solution for site.rb might also be to allow these config values to be specified by environment variables, and to make everything work with no site.rb at all.
Creating this PR mostly for discussion sake, but feel free to merge it, it's a small change which includes a documentation change.