Skip to content

NAN version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
markgis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

NAN version #1

markgis wants to merge 3 commits into from

Conversation

@markgis
Copy link

@markgis markgis commented Sep 1, 2020

Bumping NAN version seems to have fixed build for Nodes 12 , yet to test Node 14.

@markgis
Copy link
Author

markgis commented Sep 2, 2020

error: no matching member function for call to 'BooleanValue' return value->BooleanValue(); ~~~~~~~^~~~~~~~~~~~ mapbox-gl-native-node/build/headers/node/v12.18.3/v8.h:2699:8: note: candidate function not viable: requires single argument 'isolate', but no arguments were provided bool BooleanValue(Isolate* isolate) const;

My bad, looks like V8 errors still on build, got to 92% and failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@markgis