Add check for unneeded jsonl columns #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
requested review from
thepowerfuldeez
and removed request for
artek0chumak
artek0chumak
requested review from
artek0chumak
and removed request for
mryab
artek0chumak
approved these changes
Dec 5, 2024
thepowerfuldeez
approved these changes
Dec 5, 2024
thepowerfuldeez
left a comment
thepowerfuldeez
left a comment
There was a problem hiding this comment.
Approved with comments, please resolve and then we could merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check that upload jsonl files do not have columns that aren't relevant. This will also ensure all columns have the same columns.
Part of ENG-14194/fix-ft-jsonl-datasets-error-with-the-extra-column