Added query parameter to promise based get method #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

prasad610 wants to merge 1 commit into tomas:master from prasad610:issue_262_promise_does_not_send_query_parameters

+1 −1

prasad610 commented Aug 28, 2022

needle.get(
        url,
        needleOptions,
        callback
)

Needle.get does not expect any query parameters from needle options.


          Added query parameter to promise based get method

a654a28

Owner

tomas commented Nov 17, 2022

Would you include a simple test?

Also, isn't it move obvious to call the option query instead of params?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet