Destroy original digest auth request prior to making new one #442
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Just bumping this in case it got lost in the mail. |
Owner
|
Hi! Would you mind adding a test to ensure this fixes the mentioned issue? |
Author
I will work on this, yes. |
Author
|
Thank you for suggesting I write tests for this case. It looks like from my tests that I wrote that this doesn't actually solve the issue I was having. There must be something in my request layer in my app that is not behaving properly. We can close this pull request with that knowledge. |
Owner
|
Got it! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the comment in the code, the digest authentication process can result in the first request erroring out naturally. This error will make the entire needle request catch/reject. If we first destroy this old request, and then make the new one, the properly authenticated digest request may proceed regardless of the fate of the original digest request.