Skip to content

use http.CanonicalHeaderKey as it handles all normalization of eaders, fix one test, also added forwarded but TBD #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
etsangsplk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use http.CanonicalHeaderKey as it handles all normalization of eaders, fix one test, also added forwarded but TBD #7

etsangsplk wants to merge 2 commits into from

Conversation

@etsangsplk
Copy link

@etsangsplk etsangsplk commented Jul 25, 2018 •
edited
Loading

flyinprogrammer
flyinprogrammer reviewed Sep 22, 2018
View reviewed changes
realip_test.go
newRequest := func(remoteAddr, xRealIP string, xForwardedFor ...string) *http.Request {
h := http.Header{}
h.Set("X-Real-IP", xRealIP)
if xRealIP != "" {
Copy link

@flyinprogrammer flyinprogrammer Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@flyinprogrammer flyinprogrammer flyinprogrammer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@etsangsplk @flyinprogrammer