feat: extract domain packages (wikilinks, tasks, commands, embeds) #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract wikilinks into dedicated workspace package - Add core/adapters separation (pure domain vs integrations) - Add links table with SQLite migration (007_links) - Add BacklinksPanel component for note connections - Fix DOM nesting warning in preview (mdast format) - 17 new tests for wikilink parsing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Create @readied/tasks package with pure task parsing logic - countMarkdownTasks() function for progress tracking - 11 tests covering all task parsing scenarios - Moved from apps/desktop/src/renderer/utils/markdown.ts - Fix editor cursor jump bugs - Preserve selection in content update effect - Add guard + selection preservation to setCurrentNoteId effect - Export currentNoteIdField from @readied/wikilinks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Extract toolbar-commands.ts to standalone package - 15 markdown editing commands (toggleBold, insertLink, etc.) - Pure functions, no UI dependencies - CodeMirror as peerDependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Embed syntax ![[filename]] for images, videos, audio, PDFs - Core parsing: extractEmbeds(), getEmbedType() - Remark plugin for preview rendering - 18 tests covering all parsing scenarios - CSS styles for embed elements - Integrated in MarkdownPreview.tsx Note: File resolution (IPC handlers) will be added in future sprint. Currently shows placeholder for unresolved embeds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Remove unnecessary escape characters in regex character classes - Add passWithNoTests to commands vitest config 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@readied/wikilinkspackage with pure domain logic@readied/taskspackage for task parsing@readied/commandspackage for markdown toolbar commands@readied/embedspackage for embed syntax supportChanges
packages/wikilinks/,packages/tasks/,packages/commands/,packages/embeds/Test plan
pnpm testpassespnpm typecheckpasses🤖 Generated with Claude Code