Bugfixes and cosmetic tweaks #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a crash in `gui/base_instrument/InstrumentSortFilterProxyModel` that occurred when "trashed" parameters are "hidden" and the "refreshAll" button was clicked. - Removed duplicate parameter update calls in `gui/instruments`. (can be tested with `dummy_instruments/generic.DummyInstrumentTimeout`) - Ensured the server address is passed correctly to the `SubClient` in `gui/instruments/ModelParameters`, so that parameters in the GUIs can still get the update signal properly when server address is not the default 'localhost:5555'. Useful when the subscriber is not on the server PC. - Made the "instrument type" (in `gui/instruments.GenericInstrument`) still display useful class name when the instrument is a proxy. - Made the gui display floating-point numbers in scientific notation in `gui/parameters` - Made the get-only paramters also update properly when `ParameterWidget` is initialized - updated `log.QLogHandler` to highlight parameter changes, also made the it thread-safe with a html signal-slot - Added some application icons
hatlabcz
force-pushed
the
bugfixes_cosmetics
branch
from
193fafa to
1beac06
Compare
marcosfrenkel
previously approved these changes
Nov 21, 2025
marcosfrenkel
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[This PR runs in parallel with the
ClientStationupdate (PR #114). Either can be merged first, but both should follow theThreaded server(PR #113).]gui/base_instrument/InstrumentSortFilterProxyModelthat occurred when "trashed" parameters are "hidden" and the "refreshAll" button was clicked.gui/instruments. (added a get counter toparam1ofdummy_instruments/generic.DummyInstrumentTimeoutfor testing this)SubClientingui/instruments/ModelParameters, so that parameters in the GUIs can still get the update signal properly when server address is not the default 'localhost:5555'. Useful when the subscriber runs on a remote machine.gui/instruments.GenericInstrument) still display useful class name when the instrument is a proxy.gui/parametersParameterWidgetis initializedlog.QLogHandlerto highlight parameter changes, also made the it thread-safe with a html signal-slot