Skip to content

fix(PM-3404): phone icon #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hentrymartin merged 2 commits into from
Jan 27, 2026
Merged

fix(PM-3404): phone icon #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8973e31
fix: phone icon
hentrymartin Jan 27, 2026
810b8a3
fix: phone icon
hentrymartin Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/apps/profiles/src/config/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ export const PHONE_NUMBER_ROLES = [
UserRole.administrator,
UserRole.talentManager,
UserRole.projectManager,
UserRole.copilot,
]
2 changes: 1 addition & 1 deletion src/apps/profiles/src/member-profile/phones/PhoneCard/PhoneCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const PhoneCard: FC<PhoneCardProps> = (props: PhoneCardProps) => {
)}
>
{
props.canEdit && (
props.phoneIndex === 0 && (
Copy link

@github-actions github-actions bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing the condition from props.canEdit to props.phoneIndex === 0 alters the logic for displaying the phone icon. Ensure this change aligns with the intended functionality, as it may impact the display logic for users who can edit versus those who cannot.

<div className={styles.phoneIcon}>
<IconSolid.PhoneIcon />
</div>
Expand Down
Loading