Update for firstname / last name instead of handle on team leave cale… #1435
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const isSelected = selectedDates.has(dateKey) | ||
| const statusClass = styles[getStatusColor(status)] | ||
| const statusClass = styles[getStatusColor(displayStatus)] | ||
| const isDisabled = isLoading || isWeekendDate |
There was a problem hiding this comment.
[correctness]
Disabling the button for weekends (isWeekendDate) might not be the intended behavior if users should be able to select weekends for certain actions. Verify if this logic aligns with the application's requirements.
| return fullName | ||
| } | ||
|
|
||
| if (user.status === LeaveStatus.WIPRO_HOLIDAY || user.userId === 'wipro-holiday') { |
There was a problem hiding this comment.
[maintainability]
The condition user.userId === 'wipro-holiday' seems to be a hardcoded check for a specific user ID. Consider using a more flexible approach, such as a configuration or a constant, to avoid potential issues if the ID changes in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndar