Show only last runs for ai workflows -> master #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| }, [fetchError]) | ||
|
|
||
| const uniqueRuns = uniqBy(orderBy(runs, 'completedAt', 'desc'), 'workflow.id') |
There was a problem hiding this comment.
[performance]
The reverse() method is used after orderBy, which might be unnecessary if the intention is to sort in descending order. Consider removing reverse() and using orderBy(runs, 'completedAt', 'asc') if ascending order is desired.
Comment out the running_yarn_sb_build step in CircleCI config
| - run: *build_configuration_fetch | ||
| - run: *running_yarn_build | ||
| - run: *running_yarn_sb_build | ||
| # - run: *running_yarn_sb_build |
There was a problem hiding this comment.
[maintainability]
The running_yarn_sb_build step has been commented out. Ensure that this is intentional and that the Storybook build is no longer needed in the build process. If it is still required, consider implementing a conditional execution based on environment or branch to avoid unnecessary builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/
What's in this PR?