-
Notifications
You must be signed in to change notification settings - Fork 4
feat: noble curve replace elliptic #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hieu-w
wants to merge
16
commits into
master
Choose a base branch
from
feat/noble-curve-replacement
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8feec72 to
be75748
Compare
1ac76a6 to
c6f6dce
Compare
ieow
reviewed
Jan 29, 2026
This reverts commit 55af097.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
ieow
reviewed
Jan 29, 2026
ieow
approved these changes
Jan 29, 2026
ieow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
High Risk
High risk because it rewrites cryptography primitives (ECDSA/ECDH/ECIES) and changes the public API’s binary types from
BuffertoUint8Array, which can break consumers and subtly alter crypto outputs if mismatched.Overview
Switches the library’s secp256k1 backend from
ellipticto@noble/curvesand standardizes all inputs/outputs (includingEcies) onUint8Arrayinstead ofBuffer, updating key validation, signing/verifying, ECDH derivation (including padded/unpadded behavior), and ECIES encrypt/decrypt plumbing.Adds a Node-only backward-compatibility test suite (via
eccrypto-old) to compare outputs acrossgetPublic*,sign/verify,derive*, andencrypt/decrypt, adjusts browser test config to exclude those tests, and refreshes README usage/API docs plus dependency/lockfile changes to dropellipticin favor of@noble/curves.Written by Cursor Bugbot for commit b3052af. This will update automatically on new commits. Configure here.