Conversation
…/AsyncWriterResult into update-to-net8-and-add-docs # Conflicts: # .github/workflows/docs.yml
edgarfgp
had a problem deploying
to
github-pages
GitHub Actions
Failure
edgarfgp
had a problem deploying
to
github-pages
GitHub Actions
Failure
edgarfgp
had a problem deploying
to
github-pages
GitHub Actions
Failure
edgarfgp
force-pushed
the
update-to-net8-and-add-docs
branch
from
aad4cdf to
eaa8330
Compare
edgarfgp
force-pushed
the
update-to-net8-and-add-docs
branch
from
eaa8330 to
157fad3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to .NET 8.0 and adds documentation infrastructure. The changes remove two project-specific flags and add documentation-related metadata and dependencies.
Key Changes
- Upgraded target framework to .NET 8.0 with SDK version 8.0.406
- Removed
TreatWarningsAsErrorsandDisableImplicitFSharpCoreReferenceflags from the project file - Added FSharp.Docs metadata properties to the project file
- Updated dependency versions (FsCheck, FsToolkit.ErrorHandling, Mono.Cecil, Newtonsoft.Json, and System.* packages)
- Changed framework specification from
auto-detectto explicitnet8.0 - Changed FSharp.Core version constraint from
~> 8.0.403to~> 8 - Added new documentation dependencies and static assets (fonts, icons, JavaScript, CSS)
Reviewed Changes
Copilot reviewed 58 out of 117 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/AsyncWriterResult/AsyncWriterResult.fsproj | Removed two flags and added FSharp.Docs metadata links |
| paket.lock | Updated package versions for the main and Docs groups |
| paket.dependencies | Changed framework specification to net8.0 and updated FSharp.Core constraint, added doc dependencies |
| global.json | New file specifying .NET SDK 8.0.406 with latestMinor rollForward policy |
| docs/static/* | Added documentation static assets (fonts, icons, JavaScript, CSS files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
my AWR baby is growing up 🤗🥹 |
blair55
approved these changes
Nov 12, 2025
michaelwinch
approved these changes
Nov 19, 2025
edgarfgp
force-pushed
the
update-to-net8-and-add-docs
branch
from
7751a6e to
0efaef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.