Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the SSM (AWS Systems Manager) builder module by adding comprehensive documentation, new configuration options, and proper Stack integration. The changes make SSM parameters and documents first-class citizens in the FsCDK stack builder, bringing them to feature parity with other AWS resources.
Key changes:
- Added Stack.fs integration for SSM resources (new Operation types, processOperation handlers, Yield/Bind methods)
- Extended SSMParameterConfig with
DataTypeandSimpleNameproperties - Extended SSMDocumentConfig with
Attachments,Requires,UpdateMethod,VersionName, andTagsproperties - Added comprehensive XML documentation for all builder operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| src/Stack.fs | Added SSM support to Stack builder with new Operation types (SSMParameterOp, SSMDocumentOp), operation handlers, and Yield/Bind methods |
| src/SSM.fs | Enhanced SSM builders with additional configuration options, comprehensive XML documentation, and improved grammar in helper function comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.