Conversation
edgarfgp
force-pushed
the
fix-cognito-builder
branch
from
1fc967f to
1a94f8f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Cognito builders by migrating from low-level CloudFormation constructs (L1/Cfn) to higher-level CDK constructs (L2). The changes improve the API design and add comprehensive builder support for Cognito User Pool configuration.
- Migrated
UserPoolResourceServerfromCfnUserPoolResourceServerto the L2UserPoolResourceServerconstruct - Renamed the builder function from
resourceServertouserPoolResourceServerfor clarity - Added extensive builder support for User Pool configuration including password policies, sign-in aliases, auto-verified attributes, MFA settings, standard attributes, and Lambda triggers
- Added
Bindmethod forUserPoolClientSpecin the Stack builder to enable proper resource referencing - Updated tests and documentation to reflect the API changes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cognito.fs | Major refactoring: added 850+ lines of new builder implementations (PasswordPolicyBuilder, SignInAliasesBuilder, AutoVerifiedAttrsBuilder, MfaSecondFactorBuilder, StandardAttributesBuilder, UserPoolTriggersBuilder) and refactored UserPoolResourceServerBuilder to use L2 constructs with proper scope handling |
| src/Stack.fs | Changed UserPoolResourceServer instantiation from CfnUserPoolResourceServer to UserPoolResourceServer (L2 construct) and added Bind method for UserPoolClientSpec to enable monadic composition |
| tests/CognitoTests.fs | Updated tests to use userPoolResourceServer instead of resourceServer and fixed property accessor from Name to UserPoolResourceServerName to match L2 construct API |
| docs/cognito-m2m-oauth.fsx | Updated documentation examples to use userPoolResourceServer builder name consistently |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.