Merged
Conversation
edgarfgp
force-pushed
the
fix-sns-builder
branch
from
f7cc757 to
1f49513
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the SNS topic builder functionality by enabling topic resources to be bound and used within computation expressions. The changes implement the missing binding support that allows topics to be referenced in subsequent stack operations, similar to how queues and other resources work.
Key Changes:
- Added support for binding topic resources in stack builder computation expressions via new
Bindmethod - Extended TopicBuilder with 7 new AWS SNS configuration properties (encryption, logging, tracing, etc.)
- Fixed TopicSpec to store the created ITopic instance for later reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Stack.fs | Added Topic resource capture in processOperation and new Bind method for TopicSpec to enable topic binding in stack builder expressions |
| src/SNS.fs | Extended TopicConfig/TopicSpec with 7 additional SNS properties (EnforceSSL, FifoThroughputScope, LoggingConfigs, MasterKey, MessageRetentionPeriodInDays, SignatureVersion, TracingConfig) and corresponding builder methods with documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.