Skip to content

Comments

Add test coverage for missing SQS builder operations#22

Closed
Copilot wants to merge 2 commits intofix-sqs-builderfrom
copilot/sub-pr-21
Closed

Add test coverage for missing SQS builder operations#22
Copilot wants to merge 2 commits intofix-sqs-builderfrom
copilot/sub-pr-21

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Addresses feedback from #21 requesting test coverage for SQS builder operations that were added/renamed but lacked corresponding tests.

Tests Added

Added coverage for 6 operations in tests/SQSTests.fs:

  • retentionPeriod (renamed from messageRetention)
  • visibilityTimeout
  • deliveryDelay (renamed from delaySeconds)
  • dataKeyReuse
  • receiveMessageWaitTime
  • redriveAllowPolicy

Each test verifies the operation correctly sets its corresponding property on QueueProps:

test "applies visibility timeout" {
    let spec = queue "MyQueue" { visibilityTimeout 30.0 }
    Expect.isNotNull (box spec.Props.VisibilityTimeout) "VisibilityTimeout should be set"
}

Tests check for non-null properties rather than exact Duration values to avoid JSII concurrency issues during parallel test execution.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: edgarfgp <31915729+edgarfgp@users.noreply.github.com>
Copilot AI changed the title [WIP] Update SQS builder to address review feedback Add test coverage for missing SQS builder operations Dec 2, 2025
Copilot AI requested a review from edgarfgp December 2, 2025 20:37
@edgarfgp edgarfgp closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants