Add test coverage for missing SQS builder operations#22
Closed
Copilot wants to merge 2 commits intofix-sqs-builderfrom
Closed
Add test coverage for missing SQS builder operations#22Copilot wants to merge 2 commits intofix-sqs-builderfrom
Copilot wants to merge 2 commits intofix-sqs-builderfrom
Conversation
Merged
Co-authored-by: edgarfgp <31915729+edgarfgp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update SQS builder to address review feedback
Add test coverage for missing SQS builder operations
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #21 requesting test coverage for SQS builder operations that were added/renamed but lacked corresponding tests.
Tests Added
Added coverage for 6 operations in
tests/SQSTests.fs:retentionPeriod(renamed frommessageRetention)visibilityTimeoutdeliveryDelay(renamed fromdelaySeconds)dataKeyReusereceiveMessageWaitTimeredriveAllowPolicyEach test verifies the operation correctly sets its corresponding property on
QueueProps:Tests check for non-null properties rather than exact Duration values to avoid JSII concurrency issues during parallel test execution.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.