Conversation
Ugarz
commented
Oct 23, 2025
| situation: store.situation | ||
| } | ||
| if (!isEqual(data, getDefaultState())) { | ||
| if (JSON.stringify(data) !== JSON.stringify(getDefaultState())) { |
Collaborator
Author
There was a problem hiding this comment.
Here I removed a dependency from isEqual if (!isEqual(data, getDefaultState())) {..}
Ugarz
commented
Oct 23, 2025
| if: github.ref == 'refs/heads/main' | ||
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
Collaborator
Author
There was a problem hiding this comment.
I had some warnings on GITHUB_TOKEN and according to the JamesIves/github-pages-deploy-action@v4doc I think it is token which is expected.
Ugarz
commented
Oct 24, 2025
Comment on lines
+168
to
+174
| <button | ||
| class="my-2 inverted" | ||
| @click.prevent=" | ||
| deleteData(); | ||
| formKey++; | ||
| " | ||
| > |
Collaborator
Author
There was a problem hiding this comment.
Here there is a little issue with the Prettierrc configuration:
{
"$schema": "https://json.schemastore.org/prettierrc",
"semi": false,
"tabWidth": 2,
"singleQuote": true,
"printWidth": 100,
"trailingComma": "none"
}When I run yarn format with "semi": false, it removes the semi-colons ; from here and ends up with an error like:
3:56:04 PM [vite] Internal server error: Error parsing JavaScript expression: Unexpected token, expected "," (3:14)
Plugin: vite:vue
File: /home/me/dev/administrans/src/components/DocumentForm.vue:170:29
169 | class="my-2 inverted"
170 | @click.prevent="
171 | deleteData()
| ^
172 | formKey++
173 | "
My skills in Vue.js are not very sharp but maybe we can simplify deleteData()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋🏻
I had some time ahead of me so I tried to update the project dependencies (eslint configuration) and fix somes little things. The main goal was to reduce the risk surface because of vulnerabilites found with
npm audit, use a new version of Eslint v9.Changelog
IsEqualis now replaced byJSON.stringify().yarn run lintcommand to match Eslint new checkv18.19.1tov22.18.0because of the drop for old node versions.v9.38.0- documentationvite-ssgfromv0.22.2tov28.2.2(yeah it's high, but fixes high risks found in npm audit).vuefromv3.2.47tov3.5.2(vite-ssg needs).@vue/eslint-config-prettierfromv^7.1.0tov10.2.0I added some comments on the PR below 👇🏻