Skip to content

Comments

Dependency tweaks for building on Android#1160

Merged
laggui merged 3 commits intotracel-ai:mainfrom
datashapesai:fix/android-build
Feb 19, 2026
Merged

Dependency tweaks for building on Android#1160
laggui merged 3 commits intotracel-ai:mainfrom
datashapesai:fix/android-build

Conversation

@metasim
Copy link
Contributor

@metasim metasim commented Jan 23, 2026

A couple Cargo.toml tweaks to handle modern Android targets.


Validate your PR with burn.

It is important that you make sure that you don't introduce any bugs in burn.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here. ← No fixes necessary

Copilot AI review requested due to automatic review settings January 23, 2026 18:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates workspace and crate-level Cargo dependency configuration to support building CubeCL on Android targets (especially where no_std/alloc combinations matter).

Changes:

  • Enable serde_json’s alloc feature in the workspace dependency definition.
  • Extend cubecl-runtime’s target-gated “persistent cache” dependency set to include target_os = "android".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Adds serde_json alloc feature at the workspace level for broader no_std/Android compatibility.
crates/cubecl-runtime/Cargo.toml Includes Android in the target-gated dependency block used for persistent cache support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment but approving in advance

@laggui laggui merged commit be8a8b3 into tracel-ai:main Feb 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants