Dependency tweaks for building on Android#1160
Merged
laggui merged 3 commits intotracel-ai:mainfrom Feb 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates workspace and crate-level Cargo dependency configuration to support building CubeCL on Android targets (especially where no_std/alloc combinations matter).
Changes:
- Enable
serde_json’sallocfeature in the workspace dependency definition. - Extend
cubecl-runtime’s target-gated “persistent cache” dependency set to includetarget_os = "android".
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Adds serde_json alloc feature at the workspace level for broader no_std/Android compatibility. |
| crates/cubecl-runtime/Cargo.toml | Includes Android in the target-gated dependency block used for persistent cache support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
74d69c3 to
78cef44
Compare
laggui
approved these changes
Feb 18, 2026
Member
laggui
left a comment
There was a problem hiding this comment.
LGTM! Just a minor comment but approving in advance
metasim
commented
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple
Cargo.tomltweaks to handle modern Android targets.Validate your PR with burn.
It is important that you make sure that you don't introduce any bugs in burn.
Instructions