Fix setup script reliability issues for ARM64 and Docker permissions #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add architecture detection for ARM64 support in kubectl/minikube installation - Add Docker access verification with clear error messages - Remove misleading 'Optional' labels for API keys (at least one is required) - Add pre-deployment Docker check to prevent confusing errors - Remove broken demo mode option - Improve error messages and recovery instructions These changes address issues found during Ubuntu 22.04 ARM64 testing and make the setup process more robust and user-friendly.
The deployment script (crs-architecture.sh) was creating Kubernetes resources with 'kubectl create' and using '|| echo' to continue if they already existed. This caused issues when running 'helm upgrade --install' because: 1. Helm expects to manage all resources in the namespace 2. Manually created resources would conflict with Helm-managed ones 3. The error messages were misleading (said resources exist but continued) Changes: - Check if crs-instance-id configmap exists before creating - Check if registry-cache-tls secret exists before creating - Check if docker-auth secret exists before creating - Always recreate ghcr secret to ensure latest values - Remove misleading error suppression with '|| echo' This fixes the 'configmaps crs-instance-id already exists' and 'secrets registry-cache-tls already exists' errors that would cause Helm deployments to fail after an incomplete cleanup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolved conflicts in scripts/common.sh: - Kept verification logic for Anthropic API key from our branch - Added Gemini API key configuration from main - Included LLM API key validation logic from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several issues in the setup scripts discovered during testing on Ubuntu 22.04 ARM64:
Problem
Users encountered multiple failures when following the setup instructions:
Changes
Testing
Tested on:
Related Issues
Impact
These changes significantly improve the first-run experience for users, especially on:
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com