Open
Conversation
mschwager
commented
Jan 2, 2026
| TlsConfigCreationFlow::flow(source, sink) and | ||
| sink.asExpr() = v.getAReference() and | ||
| ( | ||
| sink.asExpr() = v.getAReference() or |
Member
Author
There was a problem hiding this comment.
It's challenging that this logic is duplicated in two places. That also made this fix especially hard to track down because the Variable here has to stay in sync with the Variable in isSink 😕.
I can think of a number of improvements here, but I'll save those for a separate PR and another day. Particularly, I would think that this query should be a path-problem query and all the conditions in the where clause should instead be located in the dataflow ConfigSig 🤷♂️. Using characteristic predicates for the source/StructLit and sink/Variable may also clear things up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most queries updated without problems. However,
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qltook some consideration.First, the
NamedTypeupdates fixed this warning:Second, the
sink.(DataFlow::PostUpdateNode).getPreUpdateNode()changes were due to this breaking change in thecodeql/go-alllibrary: https://github.com/github/codeql/blob/codeql-cli/latest/go/ql/lib/CHANGELOG.md#500.Specifically:
Shoutout to @owen-mc for helping me out here.