Conversation
uv does all this stuff automatically already uv run also installs the dev group by default so there's no need to make it configurable
this makes it more consistant with uv and other build tools
this makes it more consistent with uv and other build tools
|
|
ret2libc
reviewed
Sep 1, 2025
Ninja3047
force-pushed
the
modernize-python-template
branch
from
a08d9d2 to
0d0d966
Compare
also use pyproject.toml as single source of truth for version since uv does not support dynamic attribute
Ninja3047
force-pushed
the
modernize-python-template
branch
from
0d0d966 to
2509214
Compare
facutuesca
approved these changes
Sep 9, 2025
Contributor
facutuesca
left a comment
facutuesca
left a comment
There was a problem hiding this comment.
LGTM! Only one question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work done in #47
there are some potentially controversial updates so I would like some feedback
packagetarget tobuildto be more consistent withuv(and other build tools) - cc00bcdreformattarget toformatto be more consistent with upcominguv format(and other build tools) - 6de1e81uv runalready handles this in the background (including making a .venv and syncing the dev group) so I don't see a real reason to keep this around (ref https://docs.astral.sh/uv/concepts/projects/sync/#automatic-lock-and-sync). a question here would be to see if we should pass--frozento everything and let dependabot handle uv.lock updatesINSTALL_EXTRAactually doesn't really do anything here either sinceuv runwill sync thedevgroup by defaultedittarget - does anyone actually use this or find this useful? - d651385uv.locknever got updated - f839f8apyproject.tomlto prevent people's editors from adding newlines from introducing unnecessary diffs - 9e1fbc5/.githubfrom source distribution, it makes no sense to include these in the sdist since they only make sense in the context of github - dca8e19still need to test the new github workflows to make sure nothing broke