Skip to content

Replace mypy with pyright. Update Makefile dependencies.#135

Merged
Ninja3047 merged 1 commit intomainfrom
pyright
Nov 10, 2025
Merged

Replace mypy with pyright. Update Makefile dependencies.#135
Ninja3047 merged 1 commit intomainfrom
pyright

Conversation

@evandowning
Copy link
Contributor

@dhalf found that pyright might be a better solution going forward.

I had a more careful look at the differences between the two type checkers
It turns out pyright is better integrated because it is compatible with LSP. That's why we get those nice inline diagnostics and code suggestions. It also appears to be faster and more modern and more in line with new Python typing specifications (https://htmlpreview.github.io/?https://github.com/python/typing/blob/main/conformance/results/results.html).
So if we can, I think using uv + ruff + pyright is the best combination

What do you all think?

@Ninja3047
Copy link
Contributor

yeah agreed
in the future we may want to look into using astral's ty or meta's pyrefly but fine with pyright for now since that's what most people use now

@Ninja3047 Ninja3047 merged commit 26806ff into main Nov 10, 2025
6 checks passed
@Ninja3047 Ninja3047 deleted the pyright branch November 10, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants