Skip to content

Add sharp-edges-analyzer agent to sharp-edges#81

Open
dguido wants to merge 3 commits intomainfrom
add-agents-sharp-edges
Open

Add sharp-edges-analyzer agent to sharp-edges#81
dguido wants to merge 3 commits intomainfrom
add-agents-sharp-edges

Conversation

@dguido
Copy link
Member

@dguido dguido commented Feb 12, 2026

Summary

  • Adds sharp-edges-analyzer agent (Read, Grep, Glob) for evaluating APIs and configs for misuse resistance
  • 4-phase workflow: Surface Identification → Edge Case Probing → Threat Modeling → Validate Findings
  • Updates SKILL.md with agent reference section
  • Bumps plugin version to 1.1.0

New files

  • plugins/sharp-edges/agents/sharp-edges-analyzer.md (137 lines)

Test plan

  • YAML frontmatter parses correctly
  • {baseDir}/skills/sharp-edges/references/ paths resolve to existing files
  • SKILL.md changes don't break existing skill trigger behavior
  • marketplace.json version matches plugin.json (both 1.1.0)

🤖 Generated with Claude Code

dguido and others added 2 commits February 11, 2026 21:56
Introduces a formal agent definition for the sharp edges analysis
workflow. Updates SKILL.md to reference agent and bumps version
to 1.1.0.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dguido dguido requested a review from tob-scott-a as a code owner February 12, 2026 03:09
- Add examples column to agent severity classification table
- Add language-specific.md combined quick reference to agent
- Document agent in plugin README.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dguido
Copy link
Member Author

dguido commented Feb 12, 2026

Code Review Summary

Findings by severity

Severity Count
P1 (blocks merge) 0
P2 (important) 1
P3 (nice to have) 4
P4 (informational) 2

Fixed (3)

  • P2-2: Agent severity classification table was missing the Examples column present in SKILL.md. Added examples to match.
  • P3-1: Agent did not reference language-specific.md combined quick reference. Added.
  • P3-2: README.md did not mention the new agent. Added Agent section.

Dismissed (4)

  • P2-1 (content duplication between agent and SKILL.md): Agents receive only their system prompt, not the parent skill context, so self-contained instructions are necessary. This is consistent with how function-analyzer in audit-context-building is structured.
  • P3-3 (agent categories lack detailed examples): The agent is already 140 lines. Full examples would push it over 300 lines. Language-specific and cross-cutting reference files are available ON DEMAND for deeper detail.
  • P3-4 (output format missing mitigation difficulty): The existing "Recommendation" field covers this. Phase 4 "Test mitigations" is a workflow step, not an output field.
  • P4-1, P4-2 (informational): Checklist checkbox style and minor wording differences are cosmetic and consistent with existing patterns.

Quality pipeline

All CI checks pass:

  • JSON validation (marketplace.json, plugin.json)
  • Marketplace consistency (all 27 plugins validated)
  • SKILL.md frontmatter validation (all 54 skills valid)
  • No hardcoded user paths
  • No personal emails
  • Version consistency (marketplace.json and plugin.json both at 1.1.0)
  • Pre-commit hooks pass (end-of-file, trailing whitespace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant