Allow Multiple HTTP IP protocol versions at the same time#645
Draft
hasezoey wants to merge 3 commits intotramhao:masterfrom
Draft
Allow Multiple HTTP IP protocol versions at the same time#645hasezoey wants to merge 3 commits intotramhao:masterfrom
hasezoey wants to merge 3 commits intotramhao:masterfrom
Conversation
|
Looks good to me. Thank you, sir. |
|
I'm dumb, how do I "fix" it? |
Collaborator
Author
Fix what exactly, do you mean what you have mentioned in this comment? if yes, then this PR will likely not change anything for you as i dont know what could cause that. |
|
oh... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes server & tui to allow (manual) dual-stack sockets.
This is done by adding a new server config property:
[com.emulate_dual_stack]which defaults totrue, which in turn will try to listen to both ipv4 and ipv6 on the given port, but does not fail if either has error-ed, but not both.This should fix #402
Tagging some users involved and hope for feedback on if this PR fixes the issue if the config is
protocol: httpand default address of::1: @Owlyat @valkyrieglasc @DrVoidestThis should NOT be merged until some testing is done.