use fixed CPU number to determine if APERF/MPERF are supported #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small change to the
avx-turbo.cppfile. The change updates theis_supported()method to use theread_msrfunction with a CPU index of1instead of theread_msr_cur_cpufunction.I've found that the
is_supported()function while usingread_msr_cur_cpu()does not consistently return true on the same system. By always reading from a fixed CPU number, it is consistent.Determining the availability of MPERF and APERF doesn't require reading the MSR from the CPU that is currently running avx-turbo.