Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ repos:
- id: sort-simple-yaml
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 'v0.14.13'
rev: 'v0.15.2'
hooks:
- id: ruff-check
args: [--fix, --exit-non-zero-on-fix]
Expand Down
4 changes: 2 additions & 2 deletions dvc/__pyinstaller/hook-celery.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
_EXCLUDES = ("celery.bin", "celery.contrib")
hiddenimports = collect_submodules(
"celery",
filter=lambda name: not any(
is_module_or_submodule(name, module) for module in _EXCLUDES
filter=lambda name: (
not any(is_module_or_submodule(name, module) for module in _EXCLUDES)
),
)
2 changes: 1 addition & 1 deletion dvc/repo/experiments/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def _log_reproduced(self, revs: Iterable[str], tmp_dir: bool = False):
rev_names = self.get_exact_name(revs)
for rev in revs:
name = rev_names[rev]
names.append(name if name else rev[:7])
names.append(name or rev[:7])
ui.write("\nRan experiment(s): {}".format(", ".join(names)))
if tmp_dir:
ui.write(
Expand Down
2 changes: 1 addition & 1 deletion dvc/repo/experiments/collect.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def collect(
name=baseline_names.get(baseline_rev),
data=baseline_data.data,
error=baseline_data.error,
experiments=experiments if experiments else None,
experiments=experiments or None,
)
)
return result
Expand Down
2 changes: 1 addition & 1 deletion dvc/repo/experiments/executor/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ def commit(
logger.debug("Commit to current experiment branch '%s'", branch)
else:
baseline_rev = scm.get_ref(EXEC_BASELINE)
name = exp_name if exp_name else f"exp-{exp_hash[:5]}"
name = exp_name or f"exp-{exp_hash[:5]}"
ref_info = ExpRefInfo(baseline_rev, name)
branch = str(ref_info)
old_ref = None
Expand Down
2 changes: 1 addition & 1 deletion dvc/repo/experiments/refs.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class ExpRefInfo:

def __init__(self, baseline_sha: str, name: Optional[str] = None):
self.baseline_sha = baseline_sha
self.name: str = name if name else ""
self.name: str = name or ""

def __str__(self):
return "/".join(self.parts)
Expand Down
6 changes: 2 additions & 4 deletions dvc/repo/experiments/stash.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def format_message(
branch: Optional[str] = None,
) -> str:
msg = cls.MESSAGE_FORMAT.format(
rev=rev, baseline_rev=baseline_rev, name=name if name else ""
rev=rev, baseline_rev=baseline_rev, name=name or ""
)
branch_msg = f":{branch}" if branch else ""
return f"{msg}{branch_msg}"
Expand Down Expand Up @@ -124,9 +124,7 @@ def stash_revs(self) -> dict[str, ApplyStashEntry]:

@classmethod
def format_message(cls, head_rev: str, rev: str, name: Optional[str] = None) -> str:
return cls.MESSAGE_FORMAT.format(
head_rev=head_rev, rev=rev, name=name if name else ""
)
return cls.MESSAGE_FORMAT.format(head_rev=head_rev, rev=rev, name=name or "")

@contextmanager
def preserve_workspace(
Expand Down
2 changes: 1 addition & 1 deletion dvc/repo/experiments/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def exp_commits(
) -> Iterable[str]:
"""Iterate over all experiment commits."""
shas: set[str] = set()
refs = ref_infos if ref_infos else exp_refs(scm)
refs = ref_infos or exp_refs(scm)
for ref_info in refs:
shas.update(scm.branch_revs(str(ref_info), ref_info.baseline_sha))
yield from shas
Expand Down
2 changes: 1 addition & 1 deletion tests/func/experiments/test_experiments.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def test_new_simple(tmp_dir, scm, dvc, exp_stage, mocker, name, workspace):
if workspace:
assert (tmp_dir / "metrics.yaml").read_text().strip() == "foo: 2"

exp_name = name if name else ref_info.name
exp_name = name or ref_info.name
assert dvc.experiments.get_exact_name([exp])[exp] == exp_name
assert resolve_rev(scm, exp_name) == exp

Expand Down
2 changes: 1 addition & 1 deletion tests/func/experiments/test_save.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def test_exp_save(tmp_dir, dvc, scm, name):
assert ref_info
assert ref_info.baseline_sha == baseline

exp_name = name if name else ref_info.name
exp_name = name or ref_info.name
assert dvc.experiments.get_exact_name([exp])[exp] == exp_name
assert resolve_rev(scm, exp_name) == exp

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/command/test_diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def test_diff_show_markdown_and_hash(mocker, show_hash, dvc):
cmd = args.func(args)

diff = {}
show_hash = show_hash if show_hash else False
show_hash = show_hash or False
mock_show_markdown = mocker.patch("dvc.commands.diff._show_markdown")
mocker.patch("dvc.repo.Repo.diff", return_value=diff.copy())

Expand Down
Loading