Skip to content

Conversation

@trevorgrayson
Copy link
Owner

@trevorgrayson trevorgrayson commented Nov 12, 2018

Amy,

I decided I wanted to give myself a headache for a while, so I tried to abbreviate FTL's list notation. What do you think?! I think it's fortunately backwards compatible, but be brutal.

external_ids:
    - name: !lit tms
      id: /TMSid

Copy link
Collaborator

@a-e-m a-e-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok to me, though tbh we should probably clean up some of the FTLField code some

@trevorgrayson
Copy link
Owner Author

trevorgrayson commented Nov 15, 2018 via email

@a-e-m
Copy link
Collaborator

a-e-m commented Nov 15, 2018

I mostly meant like the "yuck" string and such should be cleaned up. I think the overall structure of the code is fine

@trevorgrayson
Copy link
Owner Author

trevorgrayson commented Nov 15, 2018 via email

@trevorgrayson
Copy link
Owner Author

abbreviated lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants