Skip to content

Add Close() method to logger #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
treyburn merged 4 commits into from
Nov 1, 2025

Add synctest to ensure we dont leak goroutines after close

bea1490
Select commit
Loading
Failed to load commit list.
Merged

Add Close() method to logger #18

Add synctest to ensure we dont leak goroutines after close
bea1490
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2025 in 0s

33.07% (+0.39%) compared to f6428ab

View this Pull Request on Codecov

33.07% (+0.39%) compared to f6428ab

Details

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.07%. Comparing base (f6428ab) to head (bea1490).

Files with missing lines Patch % Lines
internal/pkg/logger/postgres.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   32.68%   33.07%   +0.39%     
==========================================
  Files           5        5              
  Lines         257      263       +6     
==========================================
+ Hits           84       87       +3     
- Misses        170      173       +3     
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov