-
Notifications
You must be signed in to change notification settings - Fork 40
feat: windows build #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: windows build #697
Conversation
Summary of ChangesHello @noahpodgurski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for building and running the application on Windows. It streamlines the build process through a dedicated PowerShell script and modifies the application's boot logic to intelligently manage data and database file locations for standalone Windows binaries, significantly improving the out-of-the-box experience for Windows users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a Windows build process using a PowerShell script and adapts the application's boot sequence for standalone Windows execution. The changes are well-structured and address the goal of creating a portable Windows version. My review includes suggestions to improve the robustness of the build script by adding dependency checks and to enhance error handling in the Go code to prevent unexpected behavior regarding data storage locations. All original comments have been retained as they do not contradict the provided rules.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…server into add-windows-build
| goarch: arm64 | ||
| artifact_name: tronbyt-server-linux-arm64 | ||
| - os: macos-26 | ||
| - os: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured if we're doing windows-latest, might as well update mac, I can remove if you'd like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's better to be explicit with version numbers so that the runners don't change unexpectedly.
|
|
||
| - name: Set CGO Flags (windows) | ||
| if: matrix.goos == 'windows' | ||
| shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove the shell: bash here as it's the default.
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change.
go build -v -ldflags "${LDFLAGS}" -tags gzip_fonts -o ${{ matrix.artifact_name }} ./cmd/server only builds the server command. No need to exclude the boot command because it won't be built.
| go mod download | ||
|
|
||
| # 4. Build 'boot' (Entrypoint wrapper) | ||
| # Note: Usually on Windows you don't need this wrapper, but building it just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the boot wrapper here.
|
i wonder why the tests are failing. |
|
one of the tests |
Standalone windows builder
./build.ps1tronbyt-server.exe