-
Notifications
You must be signed in to change notification settings - Fork 261
Get started 1 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Get started 1 #522
Conversation
Correct some wording errors and grammar mistake. For the part that requires client to change, please leave it for now
| "balance": 93643857919, | ||
| "create_time": 1619681898000, | ||
| "latest_opration_time": 1655358327000, | ||
| "latest_operation_time": 1655358327000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a typo in the protocol definition, and it is better to keep the original protocol wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean keep latest_opration_time ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as 1th and 2th, the document can only be modified after actual business modifications are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean keep latest_opration_time ?
yes.
Update the wallet cli client text part according to the newest version
|
just updated on the wallet cli part; |
| No. Address Name | ||
| 1 (you wallet address) | ||
| 2 (you wallet address) | ||
| Please choose between 1 and 2, or enter search to search wallets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new version "Please choose between 1 and 2", the next input still 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on how many wallet you registered. If you input 10 wallets, it will appear 10 options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an example that requires ensuring overall logical consistency.
Correct some wording errors and grammar mistake.
For the part that requires client to change, please leave it for now
For the witness doc , i use 3 version to change it back to the original version, so nothing is changed from the master branch