✨ Update timetable layout #125
Open
+84
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psbss
reviewed
Dec 21, 2025
| "stringUnit" : { | ||
| "state" : "translated", | ||
| "value" : "開会の挨拶" | ||
| "value" : "Opening" |
Contributor
There was a problem hiding this comment.
[nits]
I know "Closing" is being translated as "クロージング" so how about it might be a good idea to translate "Opening" as "オープニング" as well.
| VStack(alignment: .leading, spacing: 8) { | ||
| ForEach(speakers) { speaker in | ||
| Image(speaker.imageFilename, description: speaker.name) | ||
| Table { |
Contributor
There was a problem hiding this comment.
[discuss]
I think this is better than the previous one, but how about displaying a "sticky header" + "tab view" when the user is using a smartphone? 👀
Contributor
There was a problem hiding this comment.
I think the quality of this PR is already good enough to merge. 🙆♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.