Skip to content

Snapshot test #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0hmX merged 12 commits into from
Dec 25, 2025
Merged

Snapshot test #42

0hmX merged 12 commits into from
Dec 25, 2025
+314 −19

Conversation

@0hmX
Copy link
Contributor

@0hmX 0hmX commented Dec 23, 2025

Add a per-layer snapshort test for rectdiffpipeline

@vercel
Copy link

vercel bot commented Dec 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
rectdiff Ready Ready Preview, Comment Dec 25, 2025 6:05am

seveibar
seveibar reviewed Dec 23, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine all the layers into a single svg with each layer labeled in a grid?

use stackSvgs or verticallyStackGraphicsObjects

looking at different files is too difficult, not useful

@seveibar
Copy link
Contributor

seveibar commented Dec 23, 2025

@0hmX actually not even a grid, this is perfect for github diffs

image

@0hmX 0hmX mentioned this pull request Dec 24, 2025
Open
@0hmX
Copy link
Contributor Author

0hmX commented Dec 24, 2025

@seveibar check out the new snapshot

seveibar
seveibar approved these changes Dec 25, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The svg is too wide, it should only be as wide as the content to make the diffs readable in github

@seveibar
Copy link
Contributor

seveibar commented Dec 25, 2025

Also show the SRJ/original in the snapshot, it will make it easier to understand

@0hmX 0hmX merged commit aa8c4ca into main Dec 25, 2025
5 checks passed
@tscircuitbot
Copy link
Contributor

tscircuitbot commented Dec 25, 2025

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imrishabh18 imrishabh18 imrishabh18 left review comments

@seveibar seveibar seveibar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0hmX @seveibar @tscircuitbot @imrishabh18