Respect board outlines when seeding candidates #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
outlinepolygon so we don't place seeds outside the board cutout.Description
outlinethrough tocomputeCandidates3DandcomputeEdgeCandidates3Dand importisPointInPolygonfor polygon checks.isPointInPolygonso points outside the outline are skipped.this.srj.outlinefromRectDiffSeedingSolverinto both candidate helpers for consistent behavior.lib/solvers/RectDiffSeedingSolver/computeCandidates3D.ts,lib/solvers/RectDiffSeedingSolver/computeEdgeCandidates3D.ts, andlib/solvers/RectDiffSeedingSolver/RectDiffSeedingSolver.ts.Testing
bunx tsc --noEmitand it completed successfully.bun testand all automated tests passed (11 pass, 1 skip, 0 fail).tests/board-outline.test.ts).Codex Task