Add weather icon URL properties to ForecastItem #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced Icon, Icon2x, Icon4x, and IconName properties to provide easy access to weather icon URLs and icon name based on the first WeatherInfo entry. These properties are marked with [JsonIgnore] to avoid serialization.
Updated the project version to 4.1.0 and revised the release notes to mention the addition of icon URLs to ForecastItem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Icon, Icon2x, Icon4x, and IconName properties to provide easy access to weather icon URLs and icon name based on the first WeatherInfo entry. These properties are marked with [JsonIgnore] to avoid serialization.
This pull request introduces enhancements to the
ForecastItemmodel in theOpenWeatherMapSharplibrary and updates the project metadata to reflect these changes. The most notable additions are new properties for weather icon URLs at various resolutions and the weather icon name.Enhancements to
ForecastItemmodel:src/OpenWeatherMapSharp/Models/ForecastItem.cs: Added new properties to provide weather icon URLs (Icon,Icon2x,Icon4x) and the weather icon name (IconName). These properties are marked with[JsonIgnore]to exclude them from JSON serialization.Project metadata updates:
src/OpenWeatherMapSharp/OpenWeatherMapSharp.csproj: Updated the project version from4.0.1to4.1.0to reflect the new features.src/OpenWeatherMapSharp/OpenWeatherMapSharp.csproj: Modified the release notes to document the addition of icon URLs toForecastItem.