Rename AirPolution* to AirPollution* for consistency #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed all classes, files, methods, and references from 'AirPolution' to the correct spelling 'AirPollution' across the codebase. This improves naming consistency and clarity throughout the project, including models, service interfaces, implementations, and related unit tests.
Changed the TargetFramework in the console project from net9.0 to net10.0 to use the latest .NET version.
Changed the target framework of the unit test project from net9.0 to net10.0 to align with the latest .NET version.
Upgraded Spectre.Console to 0.54.0 in the console sample, System.Text.Json to 10.0.0 in the main library, and test dependencies (Microsoft.NET.Test.Sdk to 18.0.1, xunit.runner.visualstudio to 3.1.5) in unit tests. This ensures compatibility with the latest features and bug fixes.
Corrected 'AirPolution' to 'AirPollution' in method names and type references in the README for consistency and accuracy.
Updated the project version to 4.2.0 and revised the release notes to mention typo fixes in the Pollution API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily fixes typos in the Pollution API by renaming all instances of "Polution" to the correct "Pollution" across the codebase, updates dependencies, and bumps the project version. These changes improve code clarity, maintainability, and ensure consistency throughout the API, documentation, and tests.
Pollution API naming corrections
AirPolution*toAirPollution*(e.g.,AirPollutionRoot,AirPollutionEntry,AirPollutionComponents,AirPollutionIndex) in theOpenWeatherMapSharp.Modelsnamespace and associated files. [1] [2] [3] [4] [5]GetAirPolution*toGetAirPollution*in interfaces, implementations, and tests. [1] [2] [3] [4] [5] [6] [7] [8] [9]Dependency and framework updates
net10.0. [1] [2]Spectre.Consoleto0.54.0,System.Text.Jsonto10.0.0, and test packages (Microsoft.NET.Test.Sdkto18.0.1,xunit.runner.visualstudioto3.1.5). [1] [2] [3]Project version and release notes
4.2.0and updated release notes to reflect the Pollution API typo fixes. [1] [2]