-
Notifications
You must be signed in to change notification settings - Fork 8
Add scripts/redeploy_ui.sh #15
base: master
Are you sure you want to change the base?
Conversation
|
If this change is accepted, we should move the setting of env variables to a shared file. I will push a PR moving them. |
|
@mareklibra want to push it? |
|
not sure why u need one more file, i think u can change deploy ui to take param and run different flow depending on it |
Wouldn't it be more confusing? I can rather add automatic detection whether the UI is already installed and then change the flow accordingly. But again: do we need such logic? By introducing new target I just follow existing approach of deploy-redeploy targets. |
|
@mareklibra i am ok with new target, just didn't want to habe one more sh file that does the same |
scripts/redeploy_ui.sh
Outdated
| export UI_PORT=${UI_PORT:-6008} | ||
| export UI_INTERNAL_PORT=80 | ||
| export KUBECONFIG=${KUBECONFIG:-$HOME/.kube/config} | ||
| export UI_SERVICE_NAME=ocp-metal-ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt it be used on line 12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
To replace existing UI image by a new one.
|
@tsorya I have added |
Use script is aimed at quick redeployment of the already deployed UI.
More-or-less just replacing the image.