Skip to content
This repository was archived by the owner on Aug 11, 2020. It is now read-only.

Conversation

@mareklibra
Copy link

Use script is aimed at quick redeployment of the already deployed UI.
More-or-less just replacing the image.

@mareklibra
Copy link
Author

If this change is accepted, we should move the setting of env variables to a shared file. I will push a PR moving them.

@tsorya
Copy link
Owner

tsorya commented Jun 1, 2020

@mareklibra want to push it?

@tsorya
Copy link
Owner

tsorya commented Jun 1, 2020

not sure why u need one more file, i think u can change deploy ui to take param and run different flow depending on it

@mareklibra
Copy link
Author

not sure why u need one more file, i think u can change deploy ui to take param and run different flow depending on it

Wouldn't it be more confusing?

I can rather add automatic detection whether the UI is already installed and then change the flow accordingly. But again: do we need such logic?

By introducing new target I just follow existing approach of deploy-redeploy targets.

@tsorya
Copy link
Owner

tsorya commented Jun 7, 2020

@mareklibra i am ok with new target, just didn't want to habe one more sh file that does the same

export UI_PORT=${UI_PORT:-6008}
export UI_INTERNAL_PORT=80
export KUBECONFIG=${KUBECONFIG:-$HOME/.kube/config}
export UI_SERVICE_NAME=ocp-metal-ui
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt it be used on line 12?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

To replace existing UI image by a new one.
@mareklibra
Copy link
Author

@tsorya I have added if into the existing scripts/deploy_ui.sh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants