Hw18 #4
Open
Hw18 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eksytnik
approved these changes
May 7, 2024
eksytnik
left a comment
eksytnik
left a comment
There was a problem hiding this comment.
Отличный код!
К чему есть вопросы:
- порядок импортов - есть автоматические штуки, которые с этим помогают, вроде isort (-2 балла)
- текст итоговых коммитов, которые отображаются в репозитории, при этом по истории видны супер осмысленные коммиты, но WIP как-то не совсем осмысленно, увы (-1 балл)
Что хочется похвалить отдельно: оформление README. И за детальное описание, и за стилистическое описание, которое не мешает читаемости. Это поднимает настроение читающему доки! +1 балл от меня лично.
Итого: 47 баллов + 1 доп
|
|
||
| def __init__(self, sequence: str): | ||
| super().__init__(sequence) | ||
| self.ALPHABET = set("AUGCaugc") |
There was a problem hiding this comment.
👍 лайк за исправления, так стало лучше в плане организации кода.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.