Move from mypy to ty

[hmgaudecker]

Lots of improvements, highlights:

• The typing of OrigParamSpec was off. What we had written was "one of two exclusive kinds of dictionaries" where we wanted to write "One dictionaries where key/value pairs can take one of two forms". Fixed via a Protocol.
• Use TypeAlias for OrderedQNames instead of TypeVar (which created a different instance per function / module).
• Define RawParamValue since we were using RawParam as a type annotation in many places where RawParam.value was passed.
• No global overrides! (Except for invalid-return-type, which is required for policy_inputs, where we annotate with the expected type, but return None)

ToDo:

• Behavior of _fail_if_requested_nodes_cannot_be_found was incorrect and tests only passed because we happened to add the item that should fail at the end, else earlier failures would get overwritten by the loop. See demonstration in this commit. Check relevant changes: git diff 12be01be395dc4db6c6f119ff3c11d0a73dd0416~2.

  When fixing the loop and not commenting out the second clause below, we saw failures.

  Issue is that when we request only upstream stuff, input-dependent interface functions like (input_data, flat) are never being created. It is not fully obvious to me why we need that check at all.

     if missing_main_targets:  # or missing_main_targets_from_include_conditions:

• When done with the above, remove "tests/test_main.py" = ["ERA001"] from pyproject.toml

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 22 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/ttsim/tt/param_objects.py	53.84%	6 Missing ⚠️
...cialized_environment_for_plotting_and_templates.py	55.55%	2 Missing and 2 partials ⚠️
src/ttsim/plot/dag/tt.py	50.00%	2 Missing and 2 partials ⚠️
src/ttsim/interface_dag_elements/backend.py	0.00%	1 Missing ⚠️
src/ttsim/interface_dag_elements/fail_if.py	93.33%	1 Missing ⚠️
src/ttsim/interface_dag_elements/tt_function.py	0.00%	1 Missing ⚠️
src/ttsim/interface_dag_elements/warn_if.py	50.00%	0 Missing and 1 partial ⚠️
src/ttsim/plot/dag/interface.py	66.66%	1 Missing ⚠️
src/ttsim/testing_utils.py	50.00%	1 Missing ⚠️
src/ttsim/tt/aggregation_jax.py	50.00%	1 Missing ⚠️
... and 1 more

📢 Thoughts on this report? Let us know!

[MImmesberger]

Issue is that when we request only upstream stuff, input-dependent interface functions like (input_data, flat) are never being created. It is not fully obvious to me why we need that check at all.

I think the idea was to check that the input-options of the input dependent interface functions (idif) are among the output of load_flat_interface_functions_and_inputs() (so before actually building the DAG).

I think this is a remnant from the times were I/we thought that idifs can be anywhere in the DAG. But then we settled on them using InterfaceInputs exclusively.

So I think we can i) remove the check, and ii) rename _fail_if_requested_nodes_cannot_be_found to _fail_if_requested_nodes_not_in_dag (took me some time to realise that).

Instead of adding a new check to main after loading all interface functions and inputs, we could also write a test that does that. We don't have many idifs and I don't think we need to check for typos in the idif definition everytime we run main.

[MImmesberger]

Cool, I think this makes the type hints much more reliable, which will be incredibly useful!