Fix version check of Urwid #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urwid used to provide `VERSION` both in its main namespace (`urwid.VERSION`) and under `version` (`urwid.version.VERSION`), but as of commit 8d8e4b678cc0f93149a4a964b26ee11fb136ea0f[1] this is now only available in the main namespace[2], as setuptools-scm does not include `VERSION` in its generated `version.py`[3]. This breaks audiotools with urwid>=2.2.0 (2023-09-21). The simple fix is to just look at `urwid.VERSION` instead of `urwid.version.VERSION`, which is what this patch does. [1] urwid/urwid@8d8e4b6 [2] urwid/urwid@8d8e4b6#diff-622c6cdaa0aebea827e82ba7a1e6127f21fe51c58ff6a88ff6b018c3885ea2e9L105-R217 [3] https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/_integration/dump_version.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urwid used to provide
VERSIONboth in its main namespace (urwid.VERSION) and underversion(urwid.version.VERSION), but as of commit 8d8e4b678cc0f93149a4a964b26ee11fb136ea0f this is now only available in the main namespace, as setuptools-scm does not includeVERSIONin its generatedversion.py. This breaks audiotools with urwid>=2.2.0 (2023-09-21).The simple fix is to just look at
urwid.VERSIONinstead ofurwid.version.VERSION, which is what this patch does.