Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

Conversation

@kev-inn
Copy link
Collaborator

@kev-inn kev-inn commented Mar 23, 2020

Switch to using SystemDSContext as a ContextManager instead of purely automatic startup and manual shutdown. This makes performance impact more obvious for the user because the expensive startup of a java process happens during SystemDSContext creation and allows for us to ensure the closing of the py4j connection and shutdown of subprocess if the user decides to use with SystemDSContext() as sds:. Manual shutdown with .close() is also possible for cases where the user wants to keep the SystemDSContext around longer, for example as an member variable of his class.

@kev-inn kev-inn linked an issue Mar 23, 2020 that may be closed by this pull request
@Shafaq-Siddiqi Shafaq-Siddiqi added WIP work in progress and removed work in progress labels Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context Manager for Python Bindings

2 participants