[pull] master from php:master #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n exception on sort The reason this happens is because the array_unique operation happens in-place because the input array is RC1. At one point during comparison an exception is thrown which will capture the arguments in the backtrace, which will increment the refcount of the RC1 array to 2. Then a modification happens after the throw on the RC2 array causing the assertion failure. We shouldn't try continue work after an exception happened during the sort. Closes GH-20059.
* PHP-8.3: Fix GH-20043: array_unique assertion failure with RC1 array causing an exception on sort
* PHP-8.4: Fix GH-20043: array_unique assertion failure with RC1 array causing an exception on sort
* PHP-8.5: Fix GH-20043: array_unique assertion failure with RC1 array causing an exception on sort
…p signature Also fixes up the error propagation at the call site which jumped to the wrong place in the error handling code. Closes GH-20057.
* PHP-8.3: phar: Fix memory leaks when creating temp file fails when applying zip signature
* PHP-8.4: phar: Fix memory leaks when creating temp file fails when applying zip signature
* PHP-8.5: phar: Fix memory leaks when creating temp file fails when applying zip signature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )