Open
Conversation
robertgotitapp
suggested changes
Aug 25, 2023
robertgotitapp
left a comment
robertgotitapp
left a comment
There was a problem hiding this comment.
Please read and reply to comment.
| import { isEmpty } from './object'; | ||
| import { MAXIMUM_RETRY_TIME } from '../constants/lib'; | ||
|
|
||
| let retryTime = 0; |
There was a problem hiding this comment.
The retryTime variable is actually shared among different requests. Thus, when the request to this end point is being called 5-10 times in a very short time, these might cause unexpected effects on each other. Please review this scenario
Author
There was a problem hiding this comment.
Can you provide me an example? Just make sure to understand what you're mentioning
There was a problem hiding this comment.
For example, what happen if there are 6 requests to giap_javascript at the same time. What would happen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test screenshot