Skip to content

Conversation

@facundominguez
Copy link
Member

No description provided.

@facundominguez facundominguez requested a review from Copilot July 13, 2025 19:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the project’s build setup to use Bazel 6 and brings related tooling declarations up to matching versions, while migrating Haskell test targets to the new ghcopts attribute and adding timeouts.

  • Bump Bazel in shell.nix and pin a newer Nixpkgs commit in nixpkgs.nix
  • Upgrade various http_archive and rule versions in WORKSPACE (rules_haskell, rules_nixpkgs, rules_go, gazelle)
  • Rename compiler_flagsghcopts across Haskell BUILD.bazel files, add timeout = "short" to tests, and update .bazelrc for Java 11

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
shell.nix Upgrade bazel_4bazel_6 in development shell
nixpkgs.nix Point to newer Nixpkgs commit and updated SHA256
jvm/BUILD.bazel Added timeout = "short" to haskell_test
jvm-types/src/test/haskell/BUILD.bazel Replace compiler_flags with ghcopts
jvm-streaming/src/test/haskell/BUILD.bazel Replace compiler_flags with ghcopts
jvm-streaming/benchmarks/BUILD.bazel Replace compiler_flags with ghcopts
jvm-batching/src/test/haskell/BUILD.bazel Replace compiler_flags with ghcopts
jvm-batching/benchmarks/BUILD.bazel Replace compiler_flags with ghcopts
examples/hello/BUILD.bazel Replace compiler_flags with ghcopts
examples/directory-server/BUILD.bazel Replace compiler_flags with ghcopts
examples/classpath/BUILD.bazel Replace compiler_flags with ghcopts
benchmarks/wizzardo-http/BUILD.bazel Replace compiler_flags with ghcopts
WORKSPACE Upgrade rule versions (rules_haskell, rules_nixpkgs, rules_go, bazel_gazelle) and reorganize Nixpkgs setup
BUILD.bazel (root) Reordered load blocks and added test timeout attrs
.bazelrc Added Java 11 flags and disabled strict Java deps
Comments suppressed due to low confidence (1)

.bazelrc:9

  • Disabling experimental_strict_java_deps can have subtle effects on Java dependency resolution; please document the rationale for turning it off.
build --experimental_strict_java_deps=off

# rule generated from jvm/jvm.cabal by gazelle_cabal
haskell_test(
name = "spec",
# keep
Copy link

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment # keep is ambiguous; consider clarifying its intent or removing it if it’s no longer needed.

Copilot uses AI. Check for mistakes.
build --java_language_version=11
build --tool_java_language_version=11
build --tool_java_runtime_version=11
build --experimental_strict_java_deps=off
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel complains otherwise that "//jvm-batching:jar" is missing from the direct dependencies of "//jvm-types:jar" even though the dependency is listed there.

@facundominguez facundominguez merged commit b2d487a into master Jul 13, 2025
3 of 4 checks passed
@facundominguez facundominguez deleted the fd/bazel6 branch July 13, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants