-
Notifications
You must be signed in to change notification settings - Fork 16
Update build configuration to bazel 6 #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the project’s build setup to use Bazel 6 and brings related tooling declarations up to matching versions, while migrating Haskell test targets to the new ghcopts attribute and adding timeouts.
- Bump Bazel in
shell.nixand pin a newer Nixpkgs commit innixpkgs.nix - Upgrade various
http_archiveand rule versions inWORKSPACE(rules_haskell, rules_nixpkgs, rules_go, gazelle) - Rename
compiler_flags→ghcoptsacross HaskellBUILD.bazelfiles, addtimeout = "short"to tests, and update.bazelrcfor Java 11
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| shell.nix | Upgrade bazel_4 → bazel_6 in development shell |
| nixpkgs.nix | Point to newer Nixpkgs commit and updated SHA256 |
| jvm/BUILD.bazel | Added timeout = "short" to haskell_test |
| jvm-types/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-streaming/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-streaming/benchmarks/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-batching/src/test/haskell/BUILD.bazel | Replace compiler_flags with ghcopts |
| jvm-batching/benchmarks/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/hello/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/directory-server/BUILD.bazel | Replace compiler_flags with ghcopts |
| examples/classpath/BUILD.bazel | Replace compiler_flags with ghcopts |
| benchmarks/wizzardo-http/BUILD.bazel | Replace compiler_flags with ghcopts |
| WORKSPACE | Upgrade rule versions (rules_haskell, rules_nixpkgs, rules_go, bazel_gazelle) and reorganize Nixpkgs setup |
| BUILD.bazel (root) | Reordered load blocks and added test timeout attrs |
| .bazelrc | Added Java 11 flags and disabled strict Java deps |
Comments suppressed due to low confidence (1)
.bazelrc:9
- Disabling
experimental_strict_java_depscan have subtle effects on Java dependency resolution; please document the rationale for turning it off.
build --experimental_strict_java_deps=off
| # rule generated from jvm/jvm.cabal by gazelle_cabal | ||
| haskell_test( | ||
| name = "spec", | ||
| # keep |
Copilot
AI
Jul 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment # keep is ambiguous; consider clarifying its intent or removing it if it’s no longer needed.
| build --java_language_version=11 | ||
| build --tool_java_language_version=11 | ||
| build --tool_java_runtime_version=11 | ||
| build --experimental_strict_java_deps=off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel complains otherwise that "//jvm-batching:jar" is missing from the direct dependencies of "//jvm-types:jar" even though the dependency is listed there.
No description provided.